From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMLW7-0008VV-6T
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:30:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMLW1-0004BL-2X
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:30:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMLW0-0004BH-QU
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:30:44 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7QIUh7c009881
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 26 Aug 2014 14:30:44 -0400
Message-ID: <53FCD24F.9050706@redhat.com>
Date: Tue, 26 Aug 2014 20:30:39 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1409077076-29855-1-git-send-email-stefanha@redhat.com>
	<1409077076-29855-3-git-send-email-stefanha@redhat.com>
In-Reply-To: <1409077076-29855-3-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-img: fix img_compare() flags
 error path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, jsnow@redhat.com, Markus Armbruster <armbru@redhat.com>

On 26.08.2014 20:17, Stefan Hajnoczi wrote:
> If img_compare() fails to parse the cache flags the goto out3 code path
> will call qemu_progress_end().  Make sure we actually call
> qemu_progress_init() first.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   qemu-img.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>