From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMLXt-0002HB-Q0 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:32:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMLXn-0004T6-MZ for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:32:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMLXn-0004Sv-Eh for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:32:35 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7QIWYMY013243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Aug 2014 14:32:34 -0400 Message-ID: <53FCD2BE.2070805@redhat.com> Date: Tue, 26 Aug 2014 20:32:30 +0200 From: Max Reitz MIME-Version: 1.0 References: <1409077076-29855-1-git-send-email-stefanha@redhat.com> <1409077076-29855-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1409077076-29855-4-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-img: always goto out in img_snapshot() error paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , jsnow@redhat.com, Markus Armbruster On 26.08.2014 20:17, Stefan Hajnoczi wrote: > The out label has the qemu_progress_end() and other cleanup calls. > Always goto out in error paths so the cleanup happens. > > Note that bdrv_unref(NULL) is safe. We just need to initialize bs to > NULL at the top of the function. > > We can now remove the obsolete bs_old_backing = NULL and bs_new_backing > = NULL for safe mode. Originally it was necessary in commit 3e85c6fd > ("qemu-img rebase") but became useless in commit c2abcce ("qemu-img: > avoid calling exit(1) to release resources properly") because the > variables are already initialized during declaration. > > Reported-by: John Snow > Signed-off-by: Stefan Hajnoczi > --- > qemu-img.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) Reviewed-by: Max Reitz