From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMTQZ-0007Wl-PY for qemu-devel@nongnu.org; Tue, 26 Aug 2014 22:57:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMTQU-00080K-Q2 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 22:57:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMTQU-00080E-Gh for qemu-devel@nongnu.org; Tue, 26 Aug 2014 22:57:34 -0400 Message-ID: <53FD491A.9060303@redhat.com> Date: Tue, 26 Aug 2014 20:57:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409086088-20910-1-git-send-email-rjones@redhat.com> <1409086088-20910-2-git-send-email-rjones@redhat.com> <20140827023845.GA2977@T430.nay.redhat.com> In-Reply-To: <20140827023845.GA2977@T430.nay.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fBRuGeMMahc4xnru3rRffHIahrFJJhBXS" Subject: Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , "Richard W.M. Jones" Cc: kwolf@redhat.com, danielhb@linux.vnet.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fBRuGeMMahc4xnru3rRffHIahrFJJhBXS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/26/2014 08:38 PM, Fam Zheng wrote: > On Tue, 08/26 21:48, Richard W.M. Jones wrote: >> Some servers (notably VMware ESX) accept range requests, but don't >> send back the Accept-Ranges: bytes header in their initial response. >> >> For these servers you can set override_accept_ranges to 'on' which >> forces this block driver to send range requests anyway. Is this a case where we should be naming with dashes instead of underscores, as in override-accept-ranges? >> @@ -489,6 +490,11 @@ static QemuOptsList runtime_opts =3D { >> .type =3D QEMU_OPT_BOOL, >> .help =3D "Verify SSL certificate" >> }, >> + { >> + .name =3D CURL_BLOCK_OPT_OVERRIDE_ACCEPT_RANGES, >> + .type =3D QEMU_OPT_BOOL, >> + .help =3D "Server accepts range requests" >> + }, It would be nice for someone to finally port the QAPI counterpart (BlockdevOptions) so that curl devices can be hotplugged via blockdev-add. But I guess that's a separate patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fBRuGeMMahc4xnru3rRffHIahrFJJhBXS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT/UkaAAoJEKeha0olJ0NqdD4IAKglg/BHkwwzNpf0zOX2FT06 XlOG+QwWOgCdqCnnnuze1ii7CUl5kbl+WAa5tmglOwWPSru9QEJa8/jHpCwLGa8b lcOFx3W7HCNQJKiHyN1hr4H1J41eXdfRUyotemRS1n0OsAruGlInEcyOoyMxtHyd afBW587ii4f8RZT1+Ina6k4r/5hjjRGBNxjFY8KVZBooG4vcng/bMmeUIsPzxq88 9pJ87BymeiIftJqYW3DVRg/yRxkqNHWtvtjTCntYvukbnU0cQMEeAteBOyJUHpJw 6SkOPftY+2XeSWeeFtOIJSs8EsT7Vi39m8VyWi2TTIRK5+N8kX2gReBNmmomviM= =Ntdt -----END PGP SIGNATURE----- --fBRuGeMMahc4xnru3rRffHIahrFJJhBXS--