From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMYkv-0003Zn-CE for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMYkp-0003Nk-7Z for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:39:01 -0400 Received: from [59.151.112.132] (port=41058 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMYko-0003Mq-PG for qemu-devel@nongnu.org; Wed, 27 Aug 2014 04:38:55 -0400 Message-ID: <53FD9959.4080503@cn.fujitsu.com> Date: Wed, 27 Aug 2014 16:39:53 +0800 From: tangchen MIME-Version: 1.0 References: <1408413327-31868-1-git-send-email-tangchen@cn.fujitsu.com> <53FC5420.6070703@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Korolyov Cc: peter.crosthwaite@xilinx.com, ehabkost@redhat.com, "Michael S. Tsirkin" , hutao@cn.fujitsu.com, "qemu-devel@nongnu.org" , tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Paolo Bonzini , Igor Mammedov On 08/26/2014 10:24 PM, Andrey Korolyov wrote: > ...... > Just to remind - Windows will not add pc dimms without populated SRAT, > so imho forcing NUMA topology to be set (and whose support is required > anyway from guest linux kernel in order to support ACPI hotplug) is > better than approach proposed by this patch. > . Hi Andrey, Sorry, I don't quite understand. If Windows won't add pc-dimm without SRAT, why is this approach not enough ? If there is no SRAT, there is no NUMA topology. Why do we need to set a NUMA topology ? Thanks.