From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XMagr-0008IF-SN
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:43:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XMagm-0006Ka-Pt
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:42:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XMagm-0006JW-I6
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:42:52 -0400
Message-ID: <53FDB623.1000908@redhat.com>
Date: Wed, 27 Aug 2014 12:42:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140826071427.1672.48119.stgit@PASHA-ISP>
	<20140826071519.1672.54843.stgit@PASHA-ISP>
	<53FC4B0D.6000906@redhat.com>
	<000f01cfc1df$db77c100$92674300$@Dovgaluk@ispras.ru>
	<53FDB1A5.9090208@redhat.com>
	<001001cfc1e1$ec844ed0$c58cec70$@Dovgaluk@ispras.ru>
In-Reply-To: <001001cfc1e1$ec844ed0$c58cec70$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru

Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto:
>> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
>> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto:
>>>>> Again, this is only needed in your record/replay system (and you haven't
>>>>> yet quite explained why the design has this limitation), so it should
>>>>> not be a part of this series.
>>>   I see. Updating s->timer and s->TimerExpire in post_load will be enough?
>>
>> In theory it should be done already, I guess it's not deterministic
>> enough though.
> 
> I split existing function into the two parts: one sets irq (and calls another).
> And the second part sets only timer and TimerExpire fields. The second function
> is also called from post_load.
> 
>> Have you tried my patch to rewrite the timer stuff?
> 
> What patch do you mean?

This one:

http://article.gmane.org/gmane.comp.emulators.qemu/288521

Paolo