From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMay0-0005OZ-B6 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 07:00:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMaxu-0003Hc-1y for qemu-devel@nongnu.org; Wed, 27 Aug 2014 07:00:40 -0400 Message-ID: <53FDBA51.6090904@suse.de> Date: Wed, 27 Aug 2014 13:00:33 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1407914453-9912-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1407914453-9912-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_pci: Fix config space corruption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 13.08.14 09:20, Alexey Kardashevskiy wrote: > When disabling MSI/MSIX via "ibm,change-msi" RTAS call, no check was made > if MSI or MSIX is actually supported and the MSI message was reset > unconditionally. If this happened on a device which does not support MSI > (but does support MSIX, otherwise "ibm,change-msi" would not be called), > this device would have PCIDevice::msi_cap field (MSI capability offset) > set to zero and writing a vector would actually clear PCI status. > > This clears MSI message only if MSI or MSIX is present on a device. > > Signed-off-by: Alexey Kardashevskiy Thanks, applied to ppc-next. Alex