From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdLl-0005Tl-P7 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMdLf-00064y-VZ for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:33:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdLf-00064s-Mj for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:33:15 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RDXEsq013374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Aug 2014 09:33:15 -0400 Message-ID: <53FDDE19.3080708@redhat.com> Date: Wed, 27 Aug 2014 07:33:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409146199-12855-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1409146199-12855-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="djHqU06POiIa8cx2LAsMVCrbtkmODDw51" Subject: Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --djHqU06POiIa8cx2LAsMVCrbtkmODDw51 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2014 07:29 AM, Stefan Hajnoczi wrote: > Name the 'granularity' parameter and give its expected value range. > Previously the device name was mistakingly reported as the parameter s/mistakingly/mistakenly/ > name. >=20 > Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR. >=20 > Reported-by: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) buf-size has the same bug a few lines later; might as well fix both at on= ce. But what you have is a strict improvement, so depending on whether you do a v2 to fix buf-size, vs. do a followup patch, you could add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --djHqU06POiIa8cx2LAsMVCrbtkmODDw51 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT/d4ZAAoJEKeha0olJ0NqXLsH/2ng5mM+03nOqnb4VyzEnDPY KQU2YB43xFxG4HbibC0qlT+Z2ujot11311r96+J+otAA6mcFHrC7QvnZe5NceFfg We60K7ILFr8groSZCaq4FJExtIqRHrtxdRw9+HfqZiRt60pMH/ouJO4wMPMLtJLm tMP/CREO0QuWBrpgJU3mt+PzVuXD9Aw3/FFeyfxvLdqlaHO4JQK43nakb/Zlu9iM CQpSGqCFADUmh2mlOehMLFv7pYyTH43EfZmF2VufpTbW7KyV5UhPtxzS3JhJ28+M g8jqpAjrCNYLQIWzxDTWDGkY2IoAuvXGNRb5AP2Rw+re0A2EL9LHH87z2bEalZM= =R/R2 -----END PGP SIGNATURE----- --djHqU06POiIa8cx2LAsMVCrbtkmODDw51--