From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhDW-00018t-KC for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMhDL-0004TJ-5w for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:41:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMhDK-0004TC-OA for qemu-devel@nongnu.org; Wed, 27 Aug 2014 13:40:55 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7RHesD9009773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Aug 2014 13:40:54 -0400 Message-ID: <53FE1822.5040407@redhat.com> Date: Wed, 27 Aug 2014 19:40:50 +0200 From: Max Reitz MIME-Version: 1.0 References: <1409119356-22742-1-git-send-email-famz@redhat.com> <1409119356-22742-5-git-send-email-famz@redhat.com> In-Reply-To: <1409119356-22742-5-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 27.08.2014 08:02, Fam Zheng wrote: > Not all the error paths release opts, fix it by moving it after the fail > label. > > Signed-off-by: Fam Zheng > --- > block/qcow2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) This is pretty much the same patch as 'qcow2: Fix leak of QemuOpts in qcow2_open()' from my 'qapi/block-core: Add "new" qcow2 options' series. I guess it's up to the maintainer(s) which one gets pulled, I just want to point out that pulling one means leaving out the other. Max