From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMo0y-0001g6-R5 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 20:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMo0s-0001DB-M7 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 20:56:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:3827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMo0s-0001D7-G7 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 20:56:30 -0400 Message-ID: <53FE7E3A.7050907@intel.com> Date: Thu, 28 Aug 2014 08:56:26 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1408584508-5946-1-git-send-email-tiejun.chen@intel.com> <1408584508-5946-3-git-send-email-tiejun.chen@intel.com> <20140821161649.GA18265@laptop.dumpdata.com> <53F6978C.9080600@intel.com> <20140824111206.GB9561@redhat.com> <53FAC70F.1080201@intel.com> <53FBF5BD.6060104@intel.com> In-Reply-To: <53FBF5BD.6060104@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, Konrad Rzeszutek Wilk >>>>>> + */ >>>>>> + dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), >>>>>> + "xen-igd-passthrough-isa-bridge"); >>>>>> + if (dev) { >>>>>> + r = xen_host_pci_device_get(&hdev, 0, 0, PCI_DEVFN(0x1f, >>>>>> 0), 0); >>>>>> + if (!r) { >>>>>> + pci_config_set_vendor_id(dev->config, hdev.vendor_id); >>>>>> + pci_config_set_device_id(dev->config, hdev.device_id); >>> >>> Can you, instead, implement the reverse logic, probing >>> the card and supplying the correct device id for PCH? >>> >> >> Here what is your so-called reverse logic as I already asked you >> previously? Do you mean I should list all PCHs with a combo illustrated >> with the vendor/device id in advance? Then look up if we can find a > > Michael, > Ping. Thanks Tiejun > Could you explain this exactly? Then I can try follow-up your idea ASAP > if this is necessary and possible. > > Thanks > Tiejun > >> matched PCH? If yes, what is that benefit you expect in passthrough >> case? Shouldn't we pass these info to VM directly in passthrough case? >> >> Thanks >> Tiejun >> >> >> > > >