From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMx8V-0002cc-Or for qemu-devel@nongnu.org; Thu, 28 Aug 2014 06:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMx8O-0003uu-8d for qemu-devel@nongnu.org; Thu, 28 Aug 2014 06:40:59 -0400 Message-ID: <53FF0732.6090008@suse.de> Date: Thu, 28 Aug 2014 12:40:50 +0200 From: Alexander Graf MIME-Version: 1.0 References: <20140825134353.2361.52046.stgit@aravindap> <20140825134516.2361.32987.stgit@aravindap> In-Reply-To: <20140825134516.2361.32987.stgit@aravindap> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aravinda Prasad , aik@au1.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Cc: benh@au1.ibm.com, paulus@samba.org On 25.08.14 15:45, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad I can't say I'm a big fan of this patch. Can we somehow separate that NMI page from the RTAS blob? Also I'd definitely prefer if we keep rtas_entry == rtas_addr - if nothing else for the sake of backwards compatibility. So how about we lay out the structure in memory like this: [ spapr-rtas.bin ] [ padding to 4k boundary or whatever sPAPR requires ] [ 4k NMI region ] Then the only thing we'd have to really change internally is the size information of the rtas blob. Alex