From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMxTs-0007Tt-Hh for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:03:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMxTn-0002TQ-Ec for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:03:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMxTn-0002TK-5m for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:02:59 -0400 Message-ID: <53FF0C37.7000802@redhat.com> Date: Thu, 28 Aug 2014 13:02:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140826071427.1672.48119.stgit@PASHA-ISP> <20140826071519.1672.54843.stgit@PASHA-ISP> <53FC4B0D.6000906@redhat.com> <000f01cfc1df$db77c100$92674300$@Dovgaluk@ispras.ru> <53FDB1A5.9090208@redhat.com> <001001cfc1e1$ec844ed0$c58cec70$@Dovgaluk@ispras.ru> <53FDB623.1000908@redhat.com> <30591.5658282631$1409136551@news.gmane.org> <53FDFE62.7040803@redhat.com> <000301cfc29a$6d7c79a0$48756ce0$@Dovgaluk@ispras.ru> In-Reply-To: <000301cfc29a$6d7c79a0$48756ce0$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru Il 28/08/2014 10:31, Pavel Dovgaluk ha scritto: >> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini >> Il 27/08/2014 12:48, Pavel Dovgaluk ha scritto: >>>> From: Paolo Bonzini [mailto:pbonzini@redhat.com] >>>> Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: >>>>>> From: Paolo Bonzini [mailto:pbonzini@redhat.com] >>>>>> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: >>>>>>>>> Again, this is only needed in your record/replay system (and you haven't >>>>>>>>> yet quite explained why the design has this limitation), so it should >>>>>>>>> not be a part of this series. >>>>>>> I see. Updating s->timer and s->TimerExpire in post_load will be enough? >>>>>> >>>>>> In theory it should be done already, I guess it's not deterministic >>>>>> enough though. >>>>> >>>>> I split existing function into the two parts: one sets irq (and calls another). >>>>> And the second part sets only timer and TimerExpire fields. The second function >>>>> is also called from post_load. >>>>> >>>>>> Have you tried my patch to rewrite the timer stuff? >>>>> >>>>> What patch do you mean? >>>> >>>> This one: >>>> >>>> http://article.gmane.org/gmane.comp.emulators.qemu/288521 >>> >>> It will solve the problem, because it removes raising an irq from >>> rtl8139_set_next_tctr_time function. >>> >>> Ok then, I'll remove my rtl8139 patch from the series. >> >> Please include that patch in your record/replay work though. I'm not >> sure if I'll have time to test it and submit it. > > Ok. Now I've fixed all issues and ready to submit the second version. > Will you review any of the other patches from the series? I reviewed all x86 patches. The ARM patches seem okay at first glance. I also noticed a couple serial port issues not related to migration, but we can handle them separately. Paolo