From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
zealot351@gmail.com, maria.klimushenkova@ispras.ru
Subject: Re: [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues
Date: Thu, 28 Aug 2014 13:59:18 +0200 [thread overview]
Message-ID: <53FF1996.3070904@redhat.com> (raw)
In-Reply-To: <20140828111822.1624.24556.stgit@PASHA-ISP>
Il 28/08/2014 13:18, Pavel Dovgalyuk ha scritto:
> This set of patches is related to migration issues in hardware devices.
> Some of the devices had fields in their states that didn't saved and restored.
> These patches add missed fields to the new subsections of the vmstates.
> For several devices (like integratorcp) the patches add new vmstates, that
> didn't exist at all.
>
> v2 changes:
> * Used vmsd field of device classes instead of vm_state_register function (as suggested by Paolo Bonzini)
> * Added more comments describing piix migration fix (as suggested by Paolo Bonzini)
> * Some fields' initializations moved from pre_load to reset functions (as suggested by Paolo Bonzini)
> * Removed patch of the rtl8139 module, because irq problem is solved by another patches (as suggested by Paolo Bonzini)
> * Changed paddr synchronization in vapic (as suggested by Paolo Bonzini)
>
> ---
>
> Pavel Dovgalyuk (12):
> integratorcp: adding vmstate for save/restore
> pcspk: adding vmstate for save/restore
> fdc: adding vmstate for save/restore
> parallel: adding vmstate for save/restore
> serial: fixing vmstate for save/restore
> apic_common: fixing loading vmstate
> apic_common: vapic_paddr synchronization fix
> hpet: fixing saving and loading process
> pckbd: adding new fields to vmstate
> piix: do not raise irq while loading vmstate
> mc146818rtc: add missed field to vmstate
> pl031: add missed field to vmstate
>
>
> hw/arm/integratorcp.c | 38 +++++++
> hw/audio/pcspk.c | 17 +++
> hw/block/fdc.c | 74 +++++++++++++
> hw/char/parallel.c | 19 +++
> hw/char/serial.c | 265 ++++++++++++++++++++++++++++++++++++++++--------
> hw/input/pckbd.c | 51 +++++++++
> hw/intc/apic_common.c | 34 ++++++
> hw/pci-host/piix.c | 26 ++++-
> hw/timer/hpet.c | 15 ---
> hw/timer/mc146818rtc.c | 25 +++++
> hw/timer/pl031.c | 3 -
> 11 files changed, 502 insertions(+), 65 deletions(-)
>
Peter, can you look at patches 1 and 12?
Paolo
prev parent reply other threads:[~2014-08-28 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 11:18 [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 01/12] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2014-09-01 17:03 ` Peter Maydell
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 02/12] pcspk: " Pavel Dovgalyuk
2014-08-28 11:56 ` Paolo Bonzini
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 03/12] fdc: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 04/12] parallel: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 05/12] serial: fixing " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 06/12] apic_common: fixing loading vmstate Pavel Dovgalyuk
2014-08-28 12:05 ` Paolo Bonzini
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 07/12] apic_common: vapic_paddr synchronization fix Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process Pavel Dovgalyuk
2014-08-28 11:58 ` Paolo Bonzini
2014-09-09 12:24 ` Paolo Bonzini
2014-09-09 12:28 ` Pavel Dovgaluk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 09/12] pckbd: adding new fields to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 10/12] piix: do not raise irq while loading vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 11/12] mc146818rtc: add missed field to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 12/12] pl031: " Pavel Dovgalyuk
2014-09-01 16:59 ` Peter Maydell
2014-09-02 9:53 ` Pavel Dovgaluk
2014-08-28 11:59 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF1996.3070904@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=maria.klimushenkova@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).