From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMyMb-0005S4-32 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMyMU-0002nz-Uq for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMyMU-0002nj-Lb for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:59:30 -0400 Message-ID: <53FF1996.3070904@redhat.com> Date: Thu, 28 Aug 2014 13:59:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140828111822.1624.24556.stgit@PASHA-ISP> In-Reply-To: <20140828111822.1624.24556.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: Peter Maydell , zealot351@gmail.com, maria.klimushenkova@ispras.ru Il 28/08/2014 13:18, Pavel Dovgalyuk ha scritto: > This set of patches is related to migration issues in hardware devices. > Some of the devices had fields in their states that didn't saved and restored. > These patches add missed fields to the new subsections of the vmstates. > For several devices (like integratorcp) the patches add new vmstates, that > didn't exist at all. > > v2 changes: > * Used vmsd field of device classes instead of vm_state_register function (as suggested by Paolo Bonzini) > * Added more comments describing piix migration fix (as suggested by Paolo Bonzini) > * Some fields' initializations moved from pre_load to reset functions (as suggested by Paolo Bonzini) > * Removed patch of the rtl8139 module, because irq problem is solved by another patches (as suggested by Paolo Bonzini) > * Changed paddr synchronization in vapic (as suggested by Paolo Bonzini) > > --- > > Pavel Dovgalyuk (12): > integratorcp: adding vmstate for save/restore > pcspk: adding vmstate for save/restore > fdc: adding vmstate for save/restore > parallel: adding vmstate for save/restore > serial: fixing vmstate for save/restore > apic_common: fixing loading vmstate > apic_common: vapic_paddr synchronization fix > hpet: fixing saving and loading process > pckbd: adding new fields to vmstate > piix: do not raise irq while loading vmstate > mc146818rtc: add missed field to vmstate > pl031: add missed field to vmstate > > > hw/arm/integratorcp.c | 38 +++++++ > hw/audio/pcspk.c | 17 +++ > hw/block/fdc.c | 74 +++++++++++++ > hw/char/parallel.c | 19 +++ > hw/char/serial.c | 265 ++++++++++++++++++++++++++++++++++++++++-------- > hw/input/pckbd.c | 51 +++++++++ > hw/intc/apic_common.c | 34 ++++++ > hw/pci-host/piix.c | 26 ++++- > hw/timer/hpet.c | 15 --- > hw/timer/mc146818rtc.c | 25 +++++ > hw/timer/pl031.c | 3 - > 11 files changed, 502 insertions(+), 65 deletions(-) > Peter, can you look at patches 1 and 12? Paolo