From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMykE-0004cG-UA for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMyk8-0001qS-Lg for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:24:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35198 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMyk8-0001qK-EZ for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:23:56 -0400 Message-ID: <53FF1F5A.90202@suse.de> Date: Thu, 28 Aug 2014 14:23:54 +0200 From: Alexander Graf MIME-Version: 1.0 References: <53FF1996.5050000@suse.de> In-Reply-To: <53FF1996.5050000@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, afaerber@suse.de, pbonzini@redhat.com On 28.08.14 13:59, Alexander Graf wrote: > > > On 15.08.14 07:29, Peter Crosthwaite wrote: >> Hi All, >> >> So phase one was the QOMification of qemu_irq. This is the next step. >> We start to setup GPIOs as proper QOM objects. Inputs are child objects >> of their device. Outputs are settable Links and connection is made >> via proper setting of a QOM link. >> >> We then cleanup Sysbus to simply re-use device level GPIOs and get rid >> of it's special IRQ handling code. >> >> Depends of my pending QOM array property stuff (the "[*]" series): >> >> https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg04116.html >> >> Changed since v1: >> Addressed Alex review >> Dropped IRQ g_new0 changes > > With this patch set applied, the e500 machine fails to start: > > $ ./ppc-softmmu/qemu-system-ppc -M ppce500 -nographic > qemu-system-ppc: attempt to add duplicate property 'sysbus-irq[*]' to > object (type 'openpic') > Aborted Andreas pointed me to his qom-next branch where patches were that apparently are a prerequisite (doh, I should've read the cover letter). Sorry for the fuss, it works like a charm ;). Alex