From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMyzN-0002XY-Ob for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMyzJ-0006gn-D8 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:39:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMyzJ-0006gh-3a for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:39:37 -0400 Message-ID: <53FF2306.40900@redhat.com> Date: Thu, 28 Aug 2014 06:39:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409146199-12855-1-git-send-email-stefanha@redhat.com> <53FDDE19.3080708@redhat.com> <20140828123158.GP26741@stefanha-thinkpad.redhat.com> In-Reply-To: <20140828123158.GP26741@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VP7orVIc1246EA0Bmj8JxeALjaK5VmOOv" Subject: Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Luiz Capitulino , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VP7orVIc1246EA0Bmj8JxeALjaK5VmOOv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/28/2014 06:31 AM, Stefan Hajnoczi wrote: > On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote: >> buf-size has the same bug a few lines later; might as well fix both at= once. >=20 > Hmm...which git tree are you looking at? Serves me right for going off of a 'git grep' rather than actually looking at the source. >=20 > I don't see any error paths for buf_size: > http://git.qemu-project.org/?p=3Dqemu.git;a=3Dblob;f=3Dblockdev.c;h=3D6= a204c662d4b648c78a379f5b8e8120254dde479;hb=3DHEAD#l2140 I _knew_ I had seen two violations: blockdev.c:2175: error_set(errp, QERR_INVALID_PARAMETER, device); blockdev.c:2179: error_set(errp, QERR_INVALID_PARAMETER, device); but based on that grep, I then _assumed_ that it was for two variables (hence my claim of granularity vs. buf_size). But as your patch fixes both violations, both related to "granularity", you are correct. Sorry for spreading confusion. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VP7orVIc1246EA0Bmj8JxeALjaK5VmOOv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT/yMGAAoJEKeha0olJ0Nq7REIAJA/cyTb4nQ0CDTrEiC3ZFKn UiRy/XEVO8hy9eCf1BUkH3P4Wzi+LC3Ng7xGK8VGVBskymkKLAeFz263TvIHbGBC c1htTFqz08YsxN+iPpqxhf26cRRLjs0vuhNpH/0U3xbcTA7NtONLS6qwD+HgvCsj R0yoU/mU3YJFDq9O5v37cBUjgqFUs4fyCbfN1qQg2q/jR4cHuvBAu4SnUH8V6/rS fkGb5ByVuriMlVflKE/XaoGE75nZRcxfh4T84yE02mEUd5ZaHIQE27+E/xxHtnV+ 8IeHKhpvKOPS8iAECKG9aXiN53ZHbf8UxBDw64MIMGg1tWq40A/XBf4K2m8tZzc= =InfI -----END PGP SIGNATURE----- --VP7orVIc1246EA0Bmj8JxeALjaK5VmOOv--