From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN5ah-0007u0-67 for qemu-devel@nongnu.org; Thu, 28 Aug 2014 15:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN5aY-00046N-5B for qemu-devel@nongnu.org; Thu, 28 Aug 2014 15:42:39 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:39451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN5aX-00046I-UB for qemu-devel@nongnu.org; Thu, 28 Aug 2014 15:42:30 -0400 Received: by mail-wi0-f181.google.com with SMTP id e4so1462861wiv.8 for ; Thu, 28 Aug 2014 12:42:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53FF8621.3040201@redhat.com> Date: Thu, 28 Aug 2014 21:42:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1409205191-11406-1-git-send-email-famz@redhat.com> <20140828152224.GA4970@irqsave.net> <53FF5040.1020608@redhat.com> In-Reply-To: <53FF5040.1020608@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , armbru@redhat.com Il 28/08/2014 17:52, Eric Blake ha scritto: > have a '*coroutine':'bool' flag here that chooses between the null: and > the null-co: protocol. (I suspect we would do the same when finaly > adding gluster to BlockdevOptions: rather than having 'gluster+tcp' and > 'gluster+udp', it would be a single 'gluster' element that can then > select transport of tcp vs. udp as an option). I'm not sure it's possible in the case of null, since the two BlockDriver structs have different function pointers. Instead, gluster has the same function pointers and just multiple names to trigger the parsing of all the URI schemes. Paolo