From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way
Date: Wed, 28 Oct 2020 15:39:21 +0100 [thread overview]
Message-ID: <53ba80fe-8e4c-88c6-181d-f3b33bf3e9bc@redhat.com> (raw)
In-Reply-To: <20201028114625.GA7355@merkur.fritz.box>
On 28/10/20 12:46, Kevin Wolf wrote:
> I don't think this is the right thing to do at this point. Making more
> use of QOM is an orthogonal problem and would only make solving this one
> harder.
Making more use of QOM will make this a non-problem. You'll just use
object-add and -object and, when you figure out the QOM schema, it will
just work.
Paolo
> The problem we have and we're trying to solve is that we have
> chardev-add (which has a QAPI schema) and -chardev (which doesn't). We
> want to get an option that is described by the schema, doesn't duplicate
> things and is still convenient to use.
>
> Whether this option starts with -chardev or with -object doesn't really
> make much of a difference. The QAPI schema you need behind it will be
> almost or even exactly the same.
next prev parent reply other threads:[~2020-10-28 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 10:10 [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way Markus Armbruster
2020-10-26 10:10 ` [PATCH 1/4] char/stdio: Fix QMP default for 'signal' Markus Armbruster
2020-10-26 10:10 ` [PATCH 2/4] char: Factor out qemu_chr_print_types() Markus Armbruster
2020-10-26 10:10 ` [PATCH 3/4] char: Flat alternative to overly nested chardev-add arguments Markus Armbruster
2020-10-27 18:23 ` Eric Blake
2020-10-28 7:33 ` Markus Armbruster
2020-10-26 10:10 ` [PATCH 4/4] qemu-storage-daemon: QAPIfy --chardev Markus Armbruster
2020-10-27 18:59 ` Eric Blake
2020-10-28 7:42 ` Markus Armbruster
2020-10-28 9:18 ` Markus Armbruster
2020-10-27 18:36 ` [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way Paolo Bonzini
2020-10-28 7:01 ` Markus Armbruster
2020-10-28 11:46 ` Kevin Wolf
2020-10-28 14:39 ` Paolo Bonzini [this message]
2020-10-28 14:59 ` Kevin Wolf
2020-10-28 15:09 ` Paolo Bonzini
2020-10-28 15:39 ` Kevin Wolf
2020-10-28 16:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ba80fe-8e4c-88c6-181d-f3b33bf3e9bc@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).