qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Laurent Vivier <lvivier@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vhost-user-test: fix leaks
Date: Wed, 6 Mar 2019 07:35:28 +0100	[thread overview]
Message-ID: <53bdf4ee-d791-9983-6f1c-72b2b96e7342@redhat.com> (raw)
In-Reply-To: <20190305225135.7060-1-marcandre.lureau@redhat.com>

On 05/03/2019 23.51, Marc-André Lureau wrote:
> Spotted by ASAN.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/vhost-user-test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 4cd0a97f13..9364227ba4 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -588,6 +588,7 @@ static void test_server_free(TestServer *server)
>          g_test_message("unable to rmdir: path (%s): %s",
>                         server->tmpfs, strerror(errno));
>      }
> +    g_free(server->tmpfs);
>  
>      qemu_chr_fe_deinit(&server->chr, true);
>  
> @@ -605,6 +606,8 @@ static void test_server_free(TestServer *server)
>  
>      g_main_loop_unref(server->loop);
>      g_main_context_unref(server->context);
> +    g_cond_clear(&server->data_cond);
> +    g_mutex_clear(&server->data_mutex);
>      g_free(server);
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>

... and queued to my qtest-next branch (unless Michael wants to take it
through hist vhost tree instead).

  reply	other threads:[~2019-03-06  6:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 22:51 [Qemu-devel] [PATCH] vhost-user-test: fix leaks Marc-André Lureau
2019-03-06  6:35 ` Thomas Huth [this message]
2019-03-06 14:17   ` Michael S. Tsirkin
2019-03-06  9:08 ` Stefano Garzarella
2019-03-06  9:28 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53bdf4ee-d791-9983-6f1c-72b2b96e7342@redhat.com \
    --to=thuth@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).