From: "Cédric Le Goater" <clg@kaod.org>
To: Hugo Landau <hlandau@devever.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation
Date: Wed, 21 Feb 2018 15:27:51 +0100 [thread overview]
Message-ID: <53c1e0f5-9652-e5da-57fb-0447b301d4f5@kaod.org> (raw)
In-Reply-To: <20180220141954.GA5614@axminster>
On 02/20/2018 03:19 PM, Hugo Landau wrote:
>> I also gave it a test on an OpenBMC romulus image. Looks fine, but that's
>> an old custom U-Boot. Which defconfig did you use for U-Boot HEAD ?
> evb-ast2500_defconfig.
ok
> FYI, these changes are necessary, but not sufficient to get u-boot HEAD
> (or for that matter u-boot 2017.11, another version tested) running.
>
> The other issues were
> - the tests
> while (!(readl(®s->ecc_test_ctrl) & SDRAM_TEST_DONE));
> and
> while (!(readl(&info->regs->config) & SDRAM_CONF_CACHE_INIT_DONE));
> which appear in various places in the u-boot source and which spin
> forever. I made u-boot work by commenting these out in u-boot rather
> than patching qemu, not familiar enough with qemu to implement this.
This patch :
https://github.com/openbmc/qemu/commit/4fb98fffd3115d8d3d0a16a1033f5335b5c0fd9b
fakes some more SDMC registers to let the SDRAM initialization run. you
might want to take a look at it.
Thanks,
C.
> - the call to reset_assert in ast2500_sdrammc_probe seems to actually
> reset the machine rather than just initialize SDRAM as it is
> apparently supposed to, leading to an infinite cycle of resets.
> Couldn't quite figure out how it was supposed to work, so I
> commented this out, since obviously qemu doesn't actually have SDRAM
> initialization requirements.
>
> The above changes plus this patch allowed u-boot to get to the u-boot
> CLI. Haven't tried booting anything with it yet though.
>
next prev parent reply other threads:[~2018-02-21 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 13:26 [Qemu-devel] [PATCH] Fix ast2500 protection register emulation Hugo Landau
2018-02-20 13:57 ` Cédric Le Goater
2018-02-20 14:19 ` Hugo Landau
2018-02-21 14:27 ` Cédric Le Goater [this message]
2018-02-20 23:01 ` Andrew Jeffery
2018-02-22 11:22 ` Peter Maydell
2018-02-22 12:46 ` no-reply
2018-02-24 0:53 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c1e0f5-9652-e5da-57fb-0447b301d4f5@kaod.org \
--to=clg@kaod.org \
--cc=hlandau@devever.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).