From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLOE0-0002Rx-IU for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLODz-0007xq-FY for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:52 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLODz-0007xO-9A for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:51 -0400 Received: by mail-wr1-f65.google.com with SMTP id o4so8022697wra.3 for ; Tue, 30 Apr 2019 01:34:51 -0700 (PDT) References: <20190430071405.16714-1-thuth@redhat.com> <20190430071405.16714-31-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <53e321c9-5ce9-14ef-9f55-b5ee1fa3f0e9@redhat.com> Date: Tue, 30 Apr 2019 10:34:47 +0200 MIME-Version: 1.0 In-Reply-To: <20190430071405.16714-31-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com, "Edgar E . Iglesias" , Alistair Francis , Paul Burton , David Gibson Cc: "Michael S. Tsirkin" , Gerd Hoffmann , Subbaraya Sundeep , Rob Herring , qemu-block@nongnu.org, Andrey Smirnov , Antony Pavlov , Joel Stanley , Beniamino Galvani , qemu-arm@nongnu.org, Jan Kiszka , Cedric Le Goater , John Snow , Igor Mitsyanko , Philippe Mathieu-Daude , Jean-Christophe Dubois , Andrew Jeffery , Peter Chubb , Aurelien Jarno On 4/30/19 9:14 AM, Thomas Huth wrote: > The PCI devices should be pulled in by default if PCI_DEVICES > is set, so there is no need anymore to enforce them in the configs > file. > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 233937f394..f23ecfd5c5 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -36,14 +36,6 @@ CONFIG_DIGIC=y > CONFIG_SABRELITE=y > CONFIG_EMCRAFT_SF2=y > CONFIG_MICROBIT=y > - > -CONFIG_VGA=y OK for this one. > - > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > - > -CONFIG_PCIE_PORT=y > -CONFIG_XIO3130=y > -CONFIG_IOH3420=y > -CONFIG_I82801B11=y Since I don't understand the extent of commit 4681867544f0, I'll let David/Edgar/Alistair review it. Regards, Phil. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C3EC43219 for ; Tue, 30 Apr 2019 08:36:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BD512080C for ; Tue, 30 Apr 2019 08:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD512080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLOFC-0003OF-O3 for qemu-devel@archiver.kernel.org; Tue, 30 Apr 2019 04:36:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLOE0-0002Rx-IU for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLODz-0007xq-FY for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:52 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLODz-0007xO-9A for qemu-devel@nongnu.org; Tue, 30 Apr 2019 04:34:51 -0400 Received: by mail-wr1-f65.google.com with SMTP id o4so8022697wra.3 for ; Tue, 30 Apr 2019 01:34:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QwgUtUJ3XYWzienweeDVQJWjW7OyoxRiZprCa9xXUFg=; b=INWnA/E5Drm9rbAwkuYQOmI4onrVZvQiT/Yked03B3ikLI2TxIyLoryLcxdPpON/rm pDrLhiZoYOIyJn4yGtyvftz56SG48FV51ttFH6cNJfNs6a5JExRe1Ee3uI27CaR3VKxQ 05gNczw1tT0DZ0HVdJNDgzVoWEcq7G3+Kp23S9ehVks/RasSiSRojbQPVFlkGz5UT+Ro qFZMEnOnbc1XvLf6DTJgHjzaggHKPmFUwceJGqRj1qlJICnFljjbn1JDfzwuHpRuEHp1 XaE9kY1Tw9rB2PEJ9VX3UJwQI4kzqWm+GkO6Kvm71UFEo02Xe0/B7c3udoQ7fu4Gvw9k wCkA== X-Gm-Message-State: APjAAAV3/LmLPRrh/sKNI2DO08Q+WoUmDrWQ3ZfrBfb7A2NLvl2fqsht 6s+NUKw4Z58DLJvgrnwj6+7ReA== X-Google-Smtp-Source: APXvYqwDo43vXZFsi1bysrX2dFt64hcjYwtXY3iDGMYzIfXa6IF9ji4jltNXv/M+48I/C2yO8lbrjg== X-Received: by 2002:a5d:698b:: with SMTP id g11mr42588747wru.65.1556613290118; Tue, 30 Apr 2019 01:34:50 -0700 (PDT) Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id r8sm11646671wrg.22.2019.04.30.01.34.47 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 01:34:49 -0700 (PDT) To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com, "Edgar E . Iglesias" , Alistair Francis , Paul Burton , David Gibson References: <20190430071405.16714-1-thuth@redhat.com> <20190430071405.16714-31-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <53e321c9-5ce9-14ef-9f55-b5ee1fa3f0e9@redhat.com> Date: Tue, 30 Apr 2019 10:34:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190430071405.16714-31-thuth@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.65 Subject: Re: [Qemu-devel] [PATCH v6 30/30] hw/arm: Remove hard-enablement of the remaining PCI devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Philippe Mathieu-Daude , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrey Smirnov , Andrew Jeffery , Joel Stanley , Subbaraya Sundeep , Beniamino Galvani , Igor Mitsyanko , Cedric Le Goater , qemu-arm@nongnu.org, Jan Kiszka , Gerd Hoffmann , Peter Chubb , Jean-Christophe Dubois , John Snow , Aurelien Jarno , Antony Pavlov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190430083447.S1dpO3GhlT0KZQJV6BRRaP5UP9YJy5APhHaicZa8Zns@z> On 4/30/19 9:14 AM, Thomas Huth wrote: > The PCI devices should be pulled in by default if PCI_DEVICES > is set, so there is no need anymore to enforce them in the configs > file. > > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 233937f394..f23ecfd5c5 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -36,14 +36,6 @@ CONFIG_DIGIC=y > CONFIG_SABRELITE=y > CONFIG_EMCRAFT_SF2=y > CONFIG_MICROBIT=y > - > -CONFIG_VGA=y OK for this one. > - > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > - > -CONFIG_PCIE_PORT=y > -CONFIG_XIO3130=y > -CONFIG_IOH3420=y > -CONFIG_I82801B11=y Since I don't understand the extent of commit 4681867544f0, I'll let David/Edgar/Alistair review it. Regards, Phil.