Re: [Qemu-devel] [PATCH v1 9/9] hw/pvrdma: Unregister from shutdown notifier when device goes down

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 2/10/19 12:45 PM, Yuval Shaia wrote:
> This hook was installed to close the device when VM is going down.
> After the device is closed there is no need to be informed on VM
> shutdown.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>   hw/rdma/vmw/pvrdma_main.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 8b379c6435..1177c0822f 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -359,6 +359,8 @@ static void pvrdma_fini(PCIDevice *pdev)
>   {
>       PVRDMADev *dev = PVRDMA_DEV(pdev);
>   
> +    notifier_remove(&dev->shutdown_notifier);
> +
>       pvrdma_qp_ops_fini();
>   
>       rdma_backend_stop(&dev->backend_dev);


Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

Thanks,
Marcel