From: Thomas Huth <thuth@redhat.com>
To: Su Hang <suhang16@mails.ucas.ac.cn>, boxafox@163.com
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 RFC 2/3] util/uri.c: remove brackets that wrap `return` statement's content.
Date: Mon, 26 Feb 2018 07:39:37 +0100 [thread overview]
Message-ID: <53f804f8-fd71-0e3f-f44c-6ca02cbf7895@redhat.com> (raw)
In-Reply-To: <1519533358-13759-3-git-send-email-suhang16@mails.ucas.ac.cn>
On 25.02.2018 05:35, Su Hang wrote:
> only remove brackets that wrap `return` statements' content.
>
> use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
> to remove pattern like this: "return (1);"
>
> Signed-off-by: Su Hang <suhang16@mails.ucas.ac.cn>
> ---
> util/uri.c | 160 ++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 80 insertions(+), 80 deletions(-)
Looks good to me!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-02-26 6:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 4:35 [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format Su Hang
2018-02-25 4:35 ` [Qemu-devel] [PATCH v4 RFC 1/3] util/uri.c: Coding style check, Only whitespace involved. Using `clang-format -i util/uri.c` first, then change back few code manually, to make sure only whitespace involved Su Hang
2018-02-26 6:32 ` Thomas Huth
2018-02-25 4:35 ` [Qemu-devel] [PATCH v4 RFC 2/3] util/uri.c: remove brackets that wrap `return` statement's content Su Hang
2018-02-26 6:39 ` Thomas Huth [this message]
2018-02-25 4:35 ` [Qemu-devel] [PATCH v4 RFC 3/3] util/uri.c: wrap single statement blocks with braces {} Su Hang
2018-02-26 6:49 ` Thomas Huth
2018-02-26 7:19 ` Su Hang
2018-02-25 4:51 ` [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format no-reply
2018-02-25 4:57 ` no-reply
2018-02-25 20:56 ` Thomas Huth
2018-02-26 2:09 ` Fam Zheng
2018-02-27 15:52 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2018-02-25 4:29 Su Hang
2018-02-25 4:29 ` [Qemu-devel] [PATCH v4 RFC 2/3] util/uri.c: remove brackets that wrap `return` statement's content Su Hang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f804f8-fd71-0e3f-f44c-6ca02cbf7895@redhat.com \
--to=thuth@redhat.com \
--cc=boxafox@163.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=suhang16@mails.ucas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).