From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH v4 2/2] util/oslib: Assert qemu_try_memalign() alignment is a power of 2
Date: Wed, 21 Oct 2020 18:21:47 +0200 [thread overview]
Message-ID: <53fe6833-719c-9449-79b7-a6b7dddd63ee@redhat.com> (raw)
In-Reply-To: <9c578c16-ad57-33d8-9900-b6513cf207e1@linaro.org>
On 10/21/20 6:01 PM, Richard Henderson wrote:
> On 10/20/20 4:17 AM, Philippe Mathieu-Daudé wrote:
>> @@ -200,6 +200,9 @@ void *qemu_try_memalign(size_t alignment, size_t size)
>>
>> if (alignment < sizeof(void*)) {
>> alignment = sizeof(void*);
>> + } else {
>> + g_assert(QEMU_IS_ALIGNED(alignment, sizeof(void *)));
>
> This is redundant with the if above, and the assert below.
Indeed, thanks =)
>
>> + g_assert(is_power_of_2(alignment));
>
>
> r~
>
prev parent reply other threads:[~2020-10-21 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 11:17 [PATCH v4 0/2] util/oslib: qemu_try_memalign() improvements Philippe Mathieu-Daudé
2020-10-20 11:17 ` [PATCH v4 1/2] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign Philippe Mathieu-Daudé
2020-10-20 11:19 ` Philippe Mathieu-Daudé
2020-10-20 11:17 ` [PATCH v4 2/2] util/oslib: Assert qemu_try_memalign() alignment is a power of 2 Philippe Mathieu-Daudé
2020-10-21 16:01 ` Richard Henderson
2020-10-21 16:21 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53fe6833-719c-9449-79b7-a6b7dddd63ee@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).