qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, benoit.canet@irqsave.net, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency
Date: Fri, 29 Aug 2014 08:38:57 +0200	[thread overview]
Message-ID: <54002001.3030601@redhat.com> (raw)
In-Reply-To: <1409275547-28984-1-git-send-email-famz@redhat.com>

Il 29/08/2014 03:25, Fam Zheng ha scritto:
> Before virtio-blk dataplane is switched to use block layer, it used to
> rely on the presence of linux-aio. Now the dependency is Linux, where
> the vring code has "#include <linux/virtio_ring.h>".

Can you instead move linux/virtio_ring.h to include/hw/virtio, with
__uNN types renamed to uNN_t?

Paolo

> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index 2063cf6..a7d5a69fe 100755
> --- a/configure
> +++ b/configure
> @@ -2939,10 +2939,10 @@ fi
>  # adjust virtio-blk-data-plane based on linux-aio
>  
>  if test "$virtio_blk_data_plane" = "yes" -a \
> -	"$linux_aio" != "yes" ; then
> -  error_exit "virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
> +	"$linux" != "yes" ; then
> +  error_exit "virtio-blk-data-plane requires Linux"
>  elif test -z "$virtio_blk_data_plane" ; then
> -  virtio_blk_data_plane=$linux_aio
> +  virtio_blk_data_plane=$linux
>  fi
>  
>  ##########################################
> 

      reply	other threads:[~2014-08-29  6:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  1:25 [Qemu-devel] [PATCH] block: Loose dataplane dependency Fam Zheng
2014-08-29  6:38 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54002001.3030601@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).