* [Qemu-devel] [PATCH] block: Loose dataplane dependency
@ 2014-08-29 1:25 Fam Zheng
2014-08-29 6:38 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2014-08-29 1:25 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini, benoit.canet, stefanha
Before virtio-blk dataplane is switched to use block layer, it used to
rely on the presence of linux-aio. Now the dependency is Linux, where
the vring code has "#include <linux/virtio_ring.h>".
Signed-off-by: Fam Zheng <famz@redhat.com>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 2063cf6..a7d5a69fe 100755
--- a/configure
+++ b/configure
@@ -2939,10 +2939,10 @@ fi
# adjust virtio-blk-data-plane based on linux-aio
if test "$virtio_blk_data_plane" = "yes" -a \
- "$linux_aio" != "yes" ; then
- error_exit "virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
+ "$linux" != "yes" ; then
+ error_exit "virtio-blk-data-plane requires Linux"
elif test -z "$virtio_blk_data_plane" ; then
- virtio_blk_data_plane=$linux_aio
+ virtio_blk_data_plane=$linux
fi
##########################################
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency
2014-08-29 1:25 [Qemu-devel] [PATCH] block: Loose dataplane dependency Fam Zheng
@ 2014-08-29 6:38 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-08-29 6:38 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: kwolf, benoit.canet, stefanha
Il 29/08/2014 03:25, Fam Zheng ha scritto:
> Before virtio-blk dataplane is switched to use block layer, it used to
> rely on the presence of linux-aio. Now the dependency is Linux, where
> the vring code has "#include <linux/virtio_ring.h>".
Can you instead move linux/virtio_ring.h to include/hw/virtio, with
__uNN types renamed to uNN_t?
Paolo
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 2063cf6..a7d5a69fe 100755
> --- a/configure
> +++ b/configure
> @@ -2939,10 +2939,10 @@ fi
> # adjust virtio-blk-data-plane based on linux-aio
>
> if test "$virtio_blk_data_plane" = "yes" -a \
> - "$linux_aio" != "yes" ; then
> - error_exit "virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
> + "$linux" != "yes" ; then
> + error_exit "virtio-blk-data-plane requires Linux"
> elif test -z "$virtio_blk_data_plane" ; then
> - virtio_blk_data_plane=$linux_aio
> + virtio_blk_data_plane=$linux
> fi
>
> ##########################################
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-29 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 1:25 [Qemu-devel] [PATCH] block: Loose dataplane dependency Fam Zheng
2014-08-29 6:38 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).