From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNFq3-00056o-T5
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 02:39:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNFpx-0007i2-NM
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 02:39:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNFpx-0007hr-Fo
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 02:39:05 -0400
Message-ID: <54002001.3030601@redhat.com>
Date: Fri, 29 Aug 2014 08:38:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1409275547-28984-1-git-send-email-famz@redhat.com>
In-Reply-To: <1409275547-28984-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, benoit.canet@irqsave.net, stefanha@redhat.com

Il 29/08/2014 03:25, Fam Zheng ha scritto:
> Before virtio-blk dataplane is switched to use block layer, it used to
> rely on the presence of linux-aio. Now the dependency is Linux, where
> the vring code has "#include <linux/virtio_ring.h>".

Can you instead move linux/virtio_ring.h to include/hw/virtio, with
__uNN types renamed to uNN_t?

Paolo

> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure b/configure
> index 2063cf6..a7d5a69fe 100755
> --- a/configure
> +++ b/configure
> @@ -2939,10 +2939,10 @@ fi
>  # adjust virtio-blk-data-plane based on linux-aio
>  
>  if test "$virtio_blk_data_plane" = "yes" -a \
> -	"$linux_aio" != "yes" ; then
> -  error_exit "virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
> +	"$linux" != "yes" ; then
> +  error_exit "virtio-blk-data-plane requires Linux"
>  elif test -z "$virtio_blk_data_plane" ; then
> -  virtio_blk_data_plane=$linux_aio
> +  virtio_blk_data_plane=$linux
>  fi
>  
>  ##########################################
>