From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNKzX-0007w4-6Q for qemu-devel@nongnu.org; Fri, 29 Aug 2014 08:09:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNKzS-0005Jp-1G for qemu-devel@nongnu.org; Fri, 29 Aug 2014 08:09:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNKzR-0005JU-Pn for qemu-devel@nongnu.org; Fri, 29 Aug 2014 08:09:13 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7TC9CYS010138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 29 Aug 2014 08:09:13 -0400 Message-ID: <54006D68.7070609@redhat.com> Date: Fri, 29 Aug 2014 06:09:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409299007-19461-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1409299007-19461-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hx5xJr0XiSPeukTED3mJltraOP11d3R2x" Subject: Re: [Qemu-devel] [PATCH v2] qxl-render: add more sanity checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hx5xJr0XiSPeukTED3mJltraOP11d3R2x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/29/2014 01:56 AM, Gerd Hoffmann wrote: > Damn, the dirty rectangle values are signed integers. So the checks > added by commit 788fbf042fc6d5aaeab56757e6dad622ac5f0c21 are not good > enouth, we also have to make sure they are not negative. s/enouth/enough/ >=20 > [ Note: There must be something broken in spice-server so we get > negative values in the first place. Bug opened: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1135372 ] >=20 > Signed-off-by: Gerd Hoffmann > --- > hw/display/qxl-render.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hx5xJr0XiSPeukTED3mJltraOP11d3R2x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUAG1oAAoJEKeha0olJ0Nqi0YH/1tQurrZd7IgCLfnvLFtJ2rh dkAg1iA+bged4vWLSeizfOWp87KZzomAOSWIXMIgmUM+DvqH9bIPxy1LMVxcFnMO B2vSS/Qxg0GBkeiS0v5fcozg2ouiDimB8NqRBeFNXS0Kgrkp4pmxjquJQg6QiVBJ scBNq+6jDRA7TpGa8+0O/UYAnzQy1XvapdFx/G3Zgh2f01FwZV+dhs8XdmMa6Rwl v+RPnZ2BTWpDVbPQcgAyQoiHfF/7wpFlG9FbgsstIBi7N212rOr8IiWkN37j5EZv XqHHWtmsIorpITSiSVK7LJLPWfJfQUsQiikDvSRJq6HpbDWmoFzr6vMZd/QEO8I= =3qvd -----END PGP SIGNATURE----- --Hx5xJr0XiSPeukTED3mJltraOP11d3R2x--