* [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams"
@ 2014-08-29 10:45 Gerd Hoffmann
2014-08-29 12:45 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2014-08-29 10:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
This reverts commit d063c3112c4cd23a479ee18720c2bd119da2d315.
"2 << x" is the same as "2 ^ (x + 1)", so the old code is correct.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 2c5c6f3..c63cadc 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1151,7 +1151,7 @@ static void xhci_reset_streams(XHCIEPContext *epctx)
static void xhci_alloc_streams(XHCIEPContext *epctx, dma_addr_t base)
{
assert(epctx->pstreams == NULL);
- epctx->nr_pstreams = 2 << (epctx->max_pstreams + 1);
+ epctx->nr_pstreams = 2 << epctx->max_pstreams;
epctx->pstreams = xhci_alloc_stream_contexts(epctx->nr_pstreams, base);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams"
2014-08-29 10:45 [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams" Gerd Hoffmann
@ 2014-08-29 12:45 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2014-08-29 12:45 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Hi,
On 08/29/2014 12:45 PM, Gerd Hoffmann wrote:
> This reverts commit d063c3112c4cd23a479ee18720c2bd119da2d315.
>
> "2 << x" is the same as "2 ^ (x + 1)", so the old code is correct.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/hcd-xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 2c5c6f3..c63cadc 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -1151,7 +1151,7 @@ static void xhci_reset_streams(XHCIEPContext *epctx)
> static void xhci_alloc_streams(XHCIEPContext *epctx, dma_addr_t base)
> {
> assert(epctx->pstreams == NULL);
> - epctx->nr_pstreams = 2 << (epctx->max_pstreams + 1);
> + epctx->nr_pstreams = 2 << epctx->max_pstreams;
> epctx->pstreams = xhci_alloc_stream_contexts(epctx->nr_pstreams, base);
> }
>
>
Right, my bad.
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-29 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 10:45 [Qemu-devel] [PATCH] Revert "xhci: Fix number of streams allocated when using streams" Gerd Hoffmann
2014-08-29 12:45 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).