* [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails
@ 2014-08-29 13:58 Paolo Bonzini
2014-08-29 14:11 ` Christian Borntraeger
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2014-08-29 13:58 UTC (permalink / raw)
To: qemu-devel; +Cc: drjones
Just go to the internal error runstate. This lets you use the "x",
"dump-guest-memory" or "info register" commands.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
kvm-all.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kvm-all.c b/kvm-all.c
index b240bf8..f5edcb1 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -1738,7 +1738,8 @@ int kvm_cpu_exec(CPUState *cpu)
}
fprintf(stderr, "error: kvm run failed %s\n",
strerror(-run_ret));
- abort();
+ ret = -1;
+ break;
}
trace_kvm_run_exit(cpu->cpu_index, run->exit_reason);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails
2014-08-29 13:58 [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails Paolo Bonzini
@ 2014-08-29 14:11 ` Christian Borntraeger
0 siblings, 0 replies; 2+ messages in thread
From: Christian Borntraeger @ 2014-08-29 14:11 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: drjones
On 29/08/14 15:58, Paolo Bonzini wrote:
> Just go to the internal error runstate. This lets you use the "x",
> "dump-guest-memory" or "info register" commands.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Very nice. This helps a lot in understanding some problems. (Even if those are rare).
Christian
> ---
> kvm-all.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index b240bf8..f5edcb1 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1738,7 +1738,8 @@ int kvm_cpu_exec(CPUState *cpu)
> }
> fprintf(stderr, "error: kvm run failed %s\n",
> strerror(-run_ret));
> - abort();
> + ret = -1;
> + break;
> }
>
> trace_kvm_run_exit(cpu->cpu_index, run->exit_reason);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-29 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29 13:58 [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails Paolo Bonzini
2014-08-29 14:11 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).