From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XNMte-0004Ua-Hi
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 10:11:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XNMtV-0008T9-Fb
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 10:11:22 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:54064)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XNMtV-0008Sq-5U
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 10:11:13 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 29 Aug 2014 15:11:11 +0100
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5E81917D8059
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2014 15:13:05 +0100 (BST)
Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com
	[9.149.37.250])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s7TEB93j46334092
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2014 14:11:09 GMT
Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s7TEB9O6006652
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2014 08:11:09 -0600
Message-ID: <540089FC.1040501@de.ibm.com>
Date: Fri, 29 Aug 2014 16:11:08 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1409320717-11186-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1409320717-11186-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] kvm: do not abort if KVM_RUN fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: drjones@redhat.com

On 29/08/14 15:58, Paolo Bonzini wrote:
> Just go to the internal error runstate.  This lets you use the "x",
> "dump-guest-memory" or "info register" commands.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

Very nice. This helps a lot in understanding some problems. (Even if those are rare).

Christian

> ---
>  kvm-all.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index b240bf8..f5edcb1 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1738,7 +1738,8 @@ int kvm_cpu_exec(CPUState *cpu)
>              }
>              fprintf(stderr, "error: kvm run failed %s\n",
>                      strerror(-run_ret));
> -            abort();
> +            ret = -1;
> +            break;
>          }
> 
>          trace_kvm_run_exit(cpu->cpu_index, run->exit_reason);
>