From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNNog-0007fJ-Ep for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:10:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNNob-0001YP-Gc for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:10:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNNob-0001YG-9f for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:10:13 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7TFABl8025900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 29 Aug 2014 11:10:12 -0400 Message-ID: <540097D2.2020200@redhat.com> Date: Fri, 29 Aug 2014 09:10:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409324592-31888-1-git-send-email-rjones@redhat.com> <1409324592-31888-2-git-send-email-rjones@redhat.com> In-Reply-To: <1409324592-31888-2-git-send-email-rjones@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MLir59tRIiNV4Fj34m1JR3KWi3W2ns6Mh" Subject: Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" , qemu-devel@nongnu.org Cc: famz@redhat.com, mbooth@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MLir59tRIiNV4Fj34m1JR3KWi3W2ns6Mh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/29/2014 09:03 AM, Richard W.M. Jones wrote: > In order to access VMware ESX efficiently, we need to send a session > cookie. This patch is very simple and just allows you to send that > session cookie. It punts on the question of how you get the session > cookie in the first place, but in practice you can just run a `curl' > command against the server and extract the cookie that way. >=20 > +++ b/qemu-options.hx > @@ -2351,6 +2351,11 @@ multiple of 512 bytes. It defaults to 256k. > @item sslverify > Whether to verify the remote server's certificate when connecting over= SSL. It > can have the value 'on' or 'off'. It defaults to 'on'. > + > +@item cookie > +Send this cookie (it can also be a list of cookies separated by ';') w= ith > +each outgoing request. Only supported when using protocols such as HT= TP > +which support cookies, otherwise ignored. ';' has to be quoted to enter it in the shell command line (but then again, the cookie probably contains literal " which also has to be quoted= ). We still don't have a QMP mapping for curl device hotplug. But when we gain one, do we really want to have a single (long) string containing multiple cookies, or would it be better to make this an array argument? On the command-line, which is nicer, taking the cookie option multiple times ('file.cookie=3Dxyz,file.cookie.abc'), taking it as an automatic array ('file.cookie.0=3Dxyz,file.cookie.1=3Dabc') or forcing the user to cram all cookies into a single option ('file.cookie=3D"xyz;abc"')? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MLir59tRIiNV4Fj34m1JR3KWi3W2ns6Mh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUAJfSAAoJEKeha0olJ0NqRP4H/2XwzATIsk1Je/EWXVf6QA0k 93+7x/+G0+Wj77dcJEeyrS0eXqL4/LLictIZI21FcHFW86oqnAzsUKlFrgj7ndp7 QM/GUCYx73iMy/6UD2ILW2gpxy0oB8/o8uYxI0V6sPeCy7fCLTlQl7b42xmz+YFf gU+o20VfyGNy+vooFlIbn+/zUhKFP1Pf6atKp+wgSuAYo+rP1LGz0Z1z6kVLqav7 R8GslfHdCAO0U0mjrZPDiiLSBnjYaBcNj2A7EjDgUJJJmTIMenJHtdM2jmnKaZfm eomqqZui5JjZANfhCA5cvkYzbFPjmbKJGabPOqYSsvweyr7wLDkGnCP0v0ORpC8= =MOzP -----END PGP SIGNATURE----- --MLir59tRIiNV4Fj34m1JR3KWi3W2ns6Mh--