From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNOHJ-0004Lv-2a for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:39:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNOHE-0001lA-1W for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:39:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNOHD-0001ky-Pt for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:39:47 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7TFdk2o007070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 29 Aug 2014 11:39:47 -0400 Message-ID: <54009EC2.30107@redhat.com> Date: Fri, 29 Aug 2014 09:39:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409324592-31888-1-git-send-email-rjones@redhat.com> <1409324592-31888-2-git-send-email-rjones@redhat.com> <540097D2.2020200@redhat.com> <20140829152848.GC1302@redhat.com> In-Reply-To: <20140829152848.GC1302@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="47v95qPMivImoFee95VvDdwkdVsNvwBqh" Subject: Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mbooth@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --47v95qPMivImoFee95VvDdwkdVsNvwBqh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/29/2014 09:28 AM, Richard W.M. Jones wrote: > On Fri, Aug 29, 2014 at 09:10:10AM -0600, Eric Blake wrote: >> On 08/29/2014 09:03 AM, Richard W.M. Jones wrote: >>> In order to access VMware ESX efficiently, we need to send a session >>> cookie. This patch is very simple and just allows you to send that >>> session cookie. It punts on the question of how you get the session >>> cookie in the first place, but in practice you can just run a `curl' >>> command against the server and extract the cookie that way. >>> >> >> We still don't have a QMP mapping for curl device hotplug. But when w= e >> gain one, do we really want to have a single (long) string containing >> multiple cookies, or would it be better to make this an array argument= ? >> On the command-line, which is nicer, taking the cookie option multipl= e >> times ('file.cookie=3Dxyz,file.cookie.abc'), taking it as an automatic= >> array ('file.cookie.0=3Dxyz,file.cookie.1=3Dabc') or forcing the user = to >> cram all cookies into a single option ('file.cookie=3D"xyz;abc"')? >=20 > For my immediate needs, I don't care at all about multiple cookies. > It's just a side-effect of the CURL API that they would work here. > I'm happy to drop all references to them from the documentation ... Okay, given that we are treating the string as an opaque passthrough to keep curl happy, and not something we are processing internally, I'm happy with keeping it as a single (long) string, and just simplifying the docs to mention that it is a string for curl to use, perhaps without needing to go into details on whether it allows one vs. multiple cookies.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --47v95qPMivImoFee95VvDdwkdVsNvwBqh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUAJ7CAAoJEKeha0olJ0NqVhoH/jG74Q7gqVtX8x0kz2k/zLHr 2s1WpAvxM+/PcrJC/G9O1q40nhTHyP4wu2/+mR1EU/GBevyfqzwHjzlqeesnl6Hu HgcS7Y2VuBQHzlTxVtmeH4H+lQRhOb6/56l4lZXERcKqiy5bYneYDKAXEqI1zLqP XmwIW+y0h+vPkxy1CF7TKRxK2mMfJsnWlGrEqc5V+023WWvqr7ZYu/dSXZ+h/vXX sbYynyX9l7p9Nwe8FYQ1OcTC0Qmmse9iOBoIfdNzlSQPB22dlcIl5Of1eoSaZwWV njtfCucrElo3ZmWAm31YLW+lCinlZSKc0i5DUawFsRbXMfc7Wo7Ub77f02vkjZM= =5BKz -----END PGP SIGNATURE----- --47v95qPMivImoFee95VvDdwkdVsNvwBqh--