From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNOaj-00073L-0z
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:00:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNOac-0000as-RP
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:59:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23207)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XNOac-0000ag-Js
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 11:59:50 -0400
Message-ID: <5400A369.3020403@redhat.com>
Date: Fri, 29 Aug 2014 17:59:37 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1409308848-5245-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1409308848-5245-3-git-send-email-marc.mari.barcelo@gmail.com>
	<20140829154936.GA19824@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140829154936.GA19824@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device
	initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, =?windows-1252?Q?Marc_Mar=ED?= <marc.mari.barcelo@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto:
> for (i = 0; i < 8; ++i) {
>     quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i);
> }
> if (qtest_big_endian() != qtest_host_endian()) {
>     quad.u64 = bswap64(quad.u64);
> }
> return quard.u64;

Why not keep the logic in Marc's patch, just replacing the union with OR
and shift?

Paolo