qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints
Date: Fri, 29 Aug 2014 09:49:02 -0700	[thread overview]
Message-ID: <5400AEFE.2020504@twiddle.net> (raw)
In-Reply-To: <1409311292-18860-1-git-send-email-peter.maydell@linaro.org>

On 08/29/2014 04:21 AM, Peter Maydell wrote:
> Peter Maydell (10):
>   exec.c: Relax restrictions on watchpoint length and alignment
>   exec.c: Provide full set of dummy wp remove functions in user-mode
>   exec.c: Record watchpoint fault address and direction
>   cpu-exec: Make debug_excp_handler a QOM CPU method
>   target-arm: Implement setting of watchpoints
>   target-arm: Move extended_addresses_enabled() to internals.h
>   target-arm: Implement handling of fired watchpoints
>   target-arm: Set DBGDSCR.MOE for debug exceptions taken to AArch32
>   target-arm: Remove comment about MDSCR_EL1 being dummy implementation
>   target-arm: Implement minimal DBGVCR, OSDLR_EL1, MDCCSR_EL0

Patches 1-3:
Reviewed-by: Richard Henderson <rth@twiddle.net>

The rest I looked through and only saw one funny bit.
In particular I didn't match up the implementation to the ARM.


r~

  parent reply	other threads:[~2014-08-29 16:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 11:21 [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 01/10] exec.c: Relax restrictions on watchpoint length and alignment Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 02/10] exec.c: Provide full set of dummy wp remove functions in user-mode Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 03/10] exec.c: Record watchpoint fault address and direction Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 04/10] cpu-exec: Make debug_excp_handler a QOM CPU method Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints Peter Maydell
2014-08-29 16:42   ` Richard Henderson
2014-08-29 16:43     ` Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 06/10] target-arm: Move extended_addresses_enabled() to internals.h Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 07/10] target-arm: Implement handling of fired watchpoints Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 08/10] target-arm: Set DBGDSCR.MOE for debug exceptions taken to AArch32 Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 09/10] target-arm: Remove comment about MDSCR_EL1 being dummy implementation Peter Maydell
2014-08-29 11:21 ` [Qemu-devel] [PATCH 10/10] target-arm: Implement minimal DBGVCR, OSDLR_EL1, MDCCSR_EL0 Peter Maydell
2014-08-29 16:49 ` Richard Henderson [this message]
2014-09-11 10:54   ` [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400AEFE.2020504@twiddle.net \
    --to=rth@twiddle.net \
    --cc=afaerber@suse.de \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).