From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNPMO-0006XV-J9
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:49:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNPMI-0000CY-Jx
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:49:12 -0400
Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:52421)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNPMI-0000CK-FM
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:49:06 -0400
Received: by mail-qa0-f50.google.com with SMTP id cm18so2424779qab.9
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2014 09:49:06 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5400AEFE.2020504@twiddle.net>
Date: Fri, 29 Aug 2014 09:49:02 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1409311292-18860-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1409311292-18860-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/10] Implement ARM architectural
	watchpoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, patches@linaro.org

On 08/29/2014 04:21 AM, Peter Maydell wrote:
> Peter Maydell (10):
>   exec.c: Relax restrictions on watchpoint length and alignment
>   exec.c: Provide full set of dummy wp remove functions in user-mode
>   exec.c: Record watchpoint fault address and direction
>   cpu-exec: Make debug_excp_handler a QOM CPU method
>   target-arm: Implement setting of watchpoints
>   target-arm: Move extended_addresses_enabled() to internals.h
>   target-arm: Implement handling of fired watchpoints
>   target-arm: Set DBGDSCR.MOE for debug exceptions taken to AArch32
>   target-arm: Remove comment about MDSCR_EL1 being dummy implementation
>   target-arm: Implement minimal DBGVCR, OSDLR_EL1, MDCCSR_EL0

Patches 1-3:
Reviewed-by: Richard Henderson <rth@twiddle.net>

The rest I looked through and only saw one funny bit.
In particular I didn't match up the implementation to the ARM.


r~