From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNRA3-0005xS-DR for qemu-devel@nongnu.org; Fri, 29 Aug 2014 14:44:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNR9u-0004iR-BK for qemu-devel@nongnu.org; Fri, 29 Aug 2014 14:44:35 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:49853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNR9u-0004iI-6y for qemu-devel@nongnu.org; Fri, 29 Aug 2014 14:44:26 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 29 Aug 2014 14:44:25 -0400 Message-ID: <5400C9CC.3010403@linux.vnet.ibm.com> Date: Fri, 29 Aug 2014 11:43:24 -0700 From: Tyrel Datwyler MIME-Version: 1.0 References: <1408407718-10835-1-git-send-email-mdroth@linux.vnet.ibm.com> <1408407718-10835-12-git-send-email-mdroth@linux.vnet.ibm.com> <53FC53BB.1050007@ozlabs.ru> In-Reply-To: <53FC53BB.1050007@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/12] spapr_events: event-scan RTAS interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , Michael Roth , qemu-devel@nongnu.org Cc: ncmike@ncultra.org, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org, agraf@suse.de On 08/26/2014 02:30 AM, Alexey Kardashevskiy wrote: > On 08/19/2014 10:21 AM, Michael Roth wrote: >> From: Tyrel Datwyler >> >> We don't actually rely on this interface to surface hotplug events, and >> instead rely on the similar-but-interrupt-driven check-exception RTAS >> interface used for EPOW events. However, the existence of this interface >> is needed to ensure guest kernels initialize the event-reporting >> interfaces which will in turn be used by userspace tools to handle these >> events, so we implement this interface as a stub. >> >> Signed-off-by: Tyrel Datwyler >> Signed-off-by: Michael Roth >> --- >> hw/ppc/spapr.c | 1 + >> hw/ppc/spapr_events.c | 9 +++++++++ >> include/hw/ppc/spapr.h | 2 ++ >> 3 files changed, 12 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 825fd31..c65b13a 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -702,6 +702,7 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, >> refpoints, sizeof(refpoints)))); >> >> _FDT((fdt_property_cell(fdt, "rtas-error-log-max", RTAS_ERROR_LOG_MAX))); >> + _FDT((fdt_property_cell(fdt, "rtas-event-scan-rate", RTAS_EVENT_SCAN_RATE))); >> >> /* >> * According to PAPR, rtas ibm,os-term, does not gaurantee a return >> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c >> index c0be0e5..bb80080 100644 >> --- a/hw/ppc/spapr_events.c >> +++ b/hw/ppc/spapr_events.c >> @@ -449,6 +449,14 @@ static void check_exception(PowerPCCPU *cpu, sPAPREnvironment *spapr, >> } >> } >> >> +static void event_scan(PowerPCCPU *cpu, sPAPREnvironment *spapr, >> + uint32_t token, uint32_t nargs, >> + target_ulong args, >> + uint32_t nret, target_ulong rets) >> +{ >> + rtas_st(rets, 0, 1); /* no error events found */ > > > rtas_st(rets, 0, RTAS_OUT_SUCCESS); > > > >> +} >> + >> void spapr_events_init(sPAPREnvironment *spapr) >> { >> spapr->check_exception_irq = xics_alloc(spapr->icp, 0, 0, false); >> @@ -456,4 +464,5 @@ void spapr_events_init(sPAPREnvironment *spapr) >> qemu_register_powerdown_notifier(&spapr->epow_notifier); >> spapr_rtas_register(RTAS_CHECK_EXCEPTION, "check-exception", >> check_exception); >> + spapr_rtas_register(RTAS_EVENT_SCAN, "event-scan", event_scan); >> } >> diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h >> index 5382bf1..aab627f 100644 >> --- a/include/hw/ppc/spapr.h >> +++ b/include/hw/ppc/spapr.h >> @@ -484,6 +484,8 @@ int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr, >> >> #define RTAS_ERROR_LOG_MAX 2048 >> >> +#define RTAS_EVENT_SCAN_RATE 1 > > 1 second? 1ms? 1 minute? :) Worth mentioning in the commit log. As per PAPR 7.3.3.1 the rate is per minute. -Tyrel > > >> + >> typedef struct sPAPRTCETable sPAPRTCETable; >> >> #define TYPE_SPAPR_TCE_TABLE "spapr-tce-table" >> > >