From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNUWN-0001Yh-5Z
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:19:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNUWF-0006Kz-Mg
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:19:51 -0400
Received: from mail-pd0-f180.google.com ([209.85.192.180]:59419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XNUWF-0006Ke-Gp
	for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:19:43 -0400
Received: by mail-pd0-f180.google.com with SMTP id p10so1323945pdj.25
	for <qemu-devel@nongnu.org>; Fri, 29 Aug 2014 15:19:07 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5400FC56.1090800@twiddle.net>
Date: Fri, 29 Aug 2014 15:19:02 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1409258680-15555-1-git-send-email-jaume.martif@gmail.com>
	<1409258680-15555-2-git-send-email-jaume.martif@gmail.com>
In-Reply-To: <1409258680-15555-2-git-send-email-jaume.martif@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/8] target-i386: x87 exception pointers
 using TCG.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jaume Marti Farriol <jaume.martif@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Vadim Rozenfeld <vrozenfe@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 08/28/2014 01:44 PM, Jaume Marti Farriol wrote:
> -void cpu_x86_fsave(CPUX86State *s, target_ulong ptr, int data32);
> -void cpu_x86_frstor(CPUX86State *s, target_ulong ptr, int data32);
> +void cpu_x86_fsave(CPUX86State *s, target_ulong ptr);
> +void cpu_x86_frstor(CPUX86State *s, target_ulong ptr);

You've split up the patches incorrectly, as you're
modifying the prototype but not the implementation.


r~