From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNV7D-0002tl-DG for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNV74-0006G8-Co for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:57:55 -0400 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:55416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNV74-0006Fh-5T for qemu-devel@nongnu.org; Fri, 29 Aug 2014 18:57:46 -0400 Received: by mail-pa0-f44.google.com with SMTP id rd3so7499711pab.31 for ; Fri, 29 Aug 2014 15:57:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <54010563.6050600@twiddle.net> Date: Fri, 29 Aug 2014 15:57:39 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1409258680-15555-1-git-send-email-jaume.martif@gmail.com> <1409258680-15555-3-git-send-email-jaume.martif@gmail.com> In-Reply-To: <1409258680-15555-3-git-send-email-jaume.martif@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/8] target-i386: x87 exception pointers using TCG. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jaume Marti Farriol , qemu-devel@nongnu.org Cc: Paolo Bonzini , =?ISO-8859-1?Q?Alex_Benn=E9e?= On 08/28/2014 01:44 PM, Jaume Marti Farriol wrote: > -void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32) > +void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32, > + int protected_mode) You ought not need two arguments here. All of the formats are mutually exclusive, so can be encoded into a single argument, replacing data32. r~