From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XO0Yg-0003R7-JI for qemu-devel@nongnu.org; Sun, 31 Aug 2014 04:32:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XO0YX-0007GR-Hr for qemu-devel@nongnu.org; Sun, 31 Aug 2014 04:32:22 -0400 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:50937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XO0YX-0007G3-6Q for qemu-devel@nongnu.org; Sun, 31 Aug 2014 04:32:13 -0400 Received: by mail-la0-f46.google.com with SMTP id pv20so4606033lab.5 for ; Sun, 31 Aug 2014 01:32:11 -0700 (PDT) Message-ID: <5402DD88.5010600@gmail.com> Date: Sun, 31 Aug 2014 11:32:08 +0300 From: Valentin Manea MIME-Version: 1.0 References: <53F704BE.6000407@mrs.ro> In-Reply-To: <53F704BE.6000407@mrs.ro> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: kwolf@redhat.com, mjt@tls.msk.ru, stefanha@redhat.com Set the IDE MMIO memory type to little endian. The ATA specs identify words part of the control commands encoded as little endian. While this has no impact on little endian systems, it's required for big endian systems(eg OpenRisc). Signed-off-by: Valentin Manea --- hw/ide/mmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/mmio.c b/hw/ide/mmio.c index 01c1d0e..334c8cc 100644 --- a/hw/ide/mmio.c +++ b/hw/ide/mmio.c @@ -82,7 +82,7 @@ static void mmio_ide_write(void *opaque, hwaddr addr, static const MemoryRegionOps mmio_ide_ops = { .read = mmio_ide_read, .write = mmio_ide_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static uint64_t mmio_ide_status_read(void *opaque, hwaddr addr, @@ -102,7 +102,7 @@ static void mmio_ide_cmd_write(void *opaque, hwaddr addr, static const MemoryRegionOps mmio_ide_cs_ops = { .read = mmio_ide_status_read, .write = mmio_ide_cmd_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription vmstate_ide_mmio = { -- 1.9.1