From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47640)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XOO46-0008Ur-RT
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:38:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XOO41-0000cP-Qd
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:38:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XOO41-0000cJ-JI
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:38:17 -0400
Message-ID: <54043E7D.4010706@redhat.com>
Date: Mon, 01 Sep 2014 11:38:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1409563995-9792-1-git-send-email-rudy.zhangmin@huawei.com>
In-Reply-To: <1409563995-9792-1-git-send-email-rudy.zhangmin@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Patch] block:qemu will crash when vhost-scsi disk
	vm reboot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Min <rudy.zhangmin@huawei.com>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, boby.chen@huawei.com, wu.wubin@huawei.com, subo7@huawei.com, mst@redhat.com

Il 01/09/2014 11:33, Zhang Min ha scritto:
> From: subo <subo7@huawei.com>
> 
> When the vm reboot, it will call virtio_scsi_handle_event(),
> for vhost-scsi device,vdev is VIRTIO_SCSI_COMMON, not VIRTIO_SCSI,
> if vdev convert to the VIRTIO_SCSI, it will cause qemu crash.
> 
> Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com>
> Signed-off-by: subo <subo7@huawei.com>
> ---
>  hw/scsi/virtio-scsi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index 86aba88..7d3bc49 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -630,7 +630,11 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev,
>  
>  static void virtio_scsi_handle_event(VirtIODevice *vdev, VirtQueue *vq)
>  {
> -    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
> +    VirtIOSCSI *s;
> +
> +    s = (VirtIOSCSI *)object_dynamic_cast((Object *)vdev, TYPE_VIRTIO_SCSI);
> +    if (!s)
> +        return;
>  
>      if (s->events_dropped) {
>          virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0);
> 

Should be already fixed in 2.1 by commit 91d670f (virtio-scsi: define
dummy handle_output for vhost-scsi vqs, 2014-06-19).

Paolo