From: David Hildenbrand <david@redhat.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hv-balloon: avoid alloca() usage
Date: Mon, 13 Nov 2023 09:59:52 +0100 [thread overview]
Message-ID: <54045bb8-8cc1-403e-b22d-2b14476e30a7@redhat.com> (raw)
In-Reply-To: <3b2253d199165648b958570d6c4db86d6ced139d.1699545634.git.maciej.szmigiero@oracle.com>
On 09.11.23 17:02, Maciej S. Szmigiero wrote:
> From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
>
> alloca() is frowned upon, replace it with g_malloc0() + g_autofree.
>
Reviewed-by: David Hildenbrand <david@redhat.com>
If this fixes a coverity issue of #number, we usually indicate that
using "CID: #number" or Fixes: CID: #number"
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-11-13 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 16:02 [PATCH] hv-balloon: avoid alloca() usage Maciej S. Szmigiero
2023-11-09 22:12 ` Philippe Mathieu-Daudé
2023-11-13 8:59 ` David Hildenbrand [this message]
2023-11-13 9:24 ` Maciej S. Szmigiero
2023-11-13 10:33 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54045bb8-8cc1-403e-b22d-2b14476e30a7@redhat.com \
--to=david@redhat.com \
--cc=mail@maciej.szmigiero.name \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).