From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
hjl.tools@gmail.com, Fam Zheng <famz@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols
Date: Mon, 01 Sep 2014 14:04:17 +0200 [thread overview]
Message-ID: <540460C1.6090806@redhat.com> (raw)
In-Reply-To: <CAFEAcA8_ycWbhi0K4qSTqU0xMbETQ1SLw-A9keBi1SJOYeLoug@mail.gmail.com>
Il 01/09/2014 13:46, Peter Maydell ha scritto:
> So we could fix this by not compiling empty files...
Easy for int128, even easier for getauxval (it's not a fastpath, so we
can move the "always return 0" version from include/qemu/osdep.h to
util/getauxval.c).
I'm not sure how to detect that there generated-tracers.c is empty.
Stefan, is it used by anything except $(CONFIG_TRACE_SIMPLE)?
> ranlib doesn't like that either (this one's a warning we've had for
> a long time):
Given this, do you consider th a blocker for this patch?
Paolo
next prev parent reply other threads:[~2014-09-01 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:35 [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols Fam Zheng
2014-09-01 10:37 ` Paolo Bonzini
2014-09-01 10:59 ` Peter Maydell
2014-09-01 11:28 ` Paolo Bonzini
2014-09-01 11:46 ` Peter Maydell
2014-09-01 12:04 ` Paolo Bonzini [this message]
2014-09-01 12:07 ` Peter Maydell
2014-09-02 1:19 ` Fam Zheng
2014-09-02 12:07 ` Paolo Bonzini
2014-09-03 3:19 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540460C1.6090806@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).