qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	jenelson@redhat.com, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation
Date: Tue, 02 Sep 2014 21:10:28 +0200	[thread overview]
Message-ID: <54061624.7090907@redhat.com> (raw)
In-Reply-To: <1409652063-32336-3-git-send-email-stefanha@redhat.com>

On 02.09.2014 12:01, Stefan Hajnoczi wrote:
> The src_cache option (-T) specifies the cache mode for backing files.
> It applies both the image's old backing file as well as the new backing
> file:
>
>    ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags,
>                    old_backing_drv, &local_err);
>    if (ret) {
>        ...
>    }
>    if (out_baseimg[0]) {
>        bs_new_backing = bdrv_new("new_backing", &error_abort);
>        ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags,
>                        new_backing_drv, &local_err);
>        if (ret) {
>            ...
>        }
>    }
>
> The documentation only mentions the new backing file but it really
> applies to both.
>
> Suggested-by: Jeff Nelson <jenelson@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   qemu-img.texi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

  reply	other threads:[~2014-09-02 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 10:01 [Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements Stefan Hajnoczi
2014-09-02 10:01 ` [Qemu-devel] [PATCH v2 1/2] qemu-img: clarify src_cache option documentation Stefan Hajnoczi
2014-09-02 19:10   ` Max Reitz
2014-09-02 10:01 ` [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase " Stefan Hajnoczi
2014-09-02 19:10   ` Max Reitz [this message]
2014-09-03 10:36 ` [Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54061624.7090907@redhat.com \
    --to=mreitz@redhat.com \
    --cc=famz@redhat.com \
    --cc=jenelson@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).