From: Max Reitz <mreitz@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Peter Lieven <pl@kamp.de>,
"Richard W.M. Jones" <rjones@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public
Date: Tue, 02 Sep 2014 23:27:00 +0200 [thread overview]
Message-ID: <54063624.6000506@redhat.com> (raw)
In-Reply-To: <29ff91b2261069ae7c2cbf83567763c53d9e9550.1409299732.git.hutao@cn.fujitsu.com>
On 29.08.2014 10:33, Hu Tao wrote:
> From: Peter Lieven <pl@kamp.de>
>
> relaxing the license to LGPLv2+ is intentional.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Benoit Canet <benoit.canet@nodalink.com>
> ---
> blockdev.c | 30 ++++++------------------------
> include/qapi/util.h | 17 +++++++++++++++++
> qapi/Makefile.objs | 1 +
> qapi/qapi-util.c | 34 ++++++++++++++++++++++++++++++++++
> 4 files changed, 58 insertions(+), 24 deletions(-)
> create mode 100644 include/qapi/util.h
> create mode 100644 qapi/qapi-util.c
Seems pretty much unchanged (except for the author note), so:
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-09-02 21:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 8:33 [Qemu-devel] [PATCH v13 0/6] qcow2, raw: add preallocation=full Hu Tao
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 1/6] block: round up file size to nearest sector Hu Tao
2014-08-29 12:50 ` Eric Blake
2014-09-04 9:33 ` Kevin Wolf
2014-09-02 21:21 ` Max Reitz
2014-09-04 9:43 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 2/6] block: don't convert file size to sector size Hu Tao
2014-09-02 21:24 ` Max Reitz
2014-09-04 9:57 ` Kevin Wolf
2014-09-05 9:07 ` Hu Tao
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public Hu Tao
2014-09-02 21:27 ` Max Reitz [this message]
2014-09-03 1:30 ` Hu Tao
2014-09-04 10:03 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-09-02 21:32 ` Max Reitz
2014-09-03 1:31 ` Hu Tao
2014-09-02 21:51 ` Eric Blake
2014-09-03 1:35 ` Hu Tao
2014-09-04 12:17 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option Hu Tao
2014-08-29 8:48 ` Richard W.M. Jones
2014-09-03 1:26 ` Hu Tao
2014-09-04 8:32 ` Hu Tao
2014-09-02 21:45 ` Max Reitz
2014-09-03 1:55 ` Hu Tao
2014-09-04 12:35 ` Kevin Wolf
2014-09-04 12:45 ` Richard W.M. Jones
2014-09-04 12:52 ` Kevin Wolf
2014-09-04 13:07 ` Richard W.M. Jones
2014-09-04 13:13 ` Daniel P. Berrange
2014-09-04 13:17 ` Kevin Wolf
2014-09-04 13:43 ` Richard W.M. Jones
2014-09-04 15:23 ` Kevin Wolf
2014-09-04 15:33 ` Richard W.M. Jones
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 6/6] qcow2: " Hu Tao
2014-09-02 21:55 ` Max Reitz
2014-09-04 13:09 ` Kevin Wolf
2014-09-09 3:23 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54063624.6000506@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).