From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOvbn-0008Ui-Lq for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:27:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOvbi-0006le-KV for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:27:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOvbi-0006lS-CW for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:27:18 -0400 Message-ID: <54063624.6000506@redhat.com> Date: Tue, 02 Sep 2014 23:27:00 +0200 From: Max Reitz MIME-Version: 1.0 References: <29ff91b2261069ae7c2cbf83567763c53d9e9550.1409299732.git.hutao@cn.fujitsu.com> In-Reply-To: <29ff91b2261069ae7c2cbf83567763c53d9e9550.1409299732.git.hutao@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Peter Lieven , "Richard W.M. Jones" , Stefan Hajnoczi , Yasunori Goto On 29.08.2014 10:33, Hu Tao wrote: > From: Peter Lieven > > relaxing the license to LGPLv2+ is intentional. > > Suggested-by: Markus Armbruster > Signed-off-by: Hu Tao > Signed-off-by: Peter Lieven > Reviewed-by: Eric Blake > Reviewed-by: Benoit Canet > --- > blockdev.c | 30 ++++++------------------------ > include/qapi/util.h | 17 +++++++++++++++++ > qapi/Makefile.objs | 1 + > qapi/qapi-util.c | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 24 deletions(-) > create mode 100644 include/qapi/util.h > create mode 100644 qapi/qapi-util.c Seems pretty much unchanged (except for the author note), so: Reviewed-by: Max Reitz