From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOw3L-0001AL-3U for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOw3D-0007s9-Ps for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:55:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOw3D-0007rq-Dp for qemu-devel@nongnu.org; Tue, 02 Sep 2014 17:55:43 -0400 Message-ID: <54063CD6.2060507@redhat.com> Date: Tue, 02 Sep 2014 23:55:34 +0200 From: Max Reitz MIME-Version: 1.0 References: <4b14d32b73bf4c0e234771e802a819df4a9e1bb1.1409299732.git.hutao@cn.fujitsu.com> In-Reply-To: <4b14d32b73bf4c0e234771e802a819df4a9e1bb1.1409299732.git.hutao@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 6/6] qcow2: Add full preallocation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , "Richard W.M. Jones" , Stefan Hajnoczi , Yasunori Goto On 29.08.2014 10:33, Hu Tao wrote: > preallocation=full allocates disk space by fallocating the space if > posix_fallocate() is available, otherwise by writing zeros to disk to > ensure disk space in any cases. > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 61 +++++++++++++++++++++++++++++++++++++++------- > qemu-doc.texi | 7 +++--- > qemu-img.texi | 7 +++--- > tests/qemu-iotests/082.out | 54 ++++++++++++++++++++-------------------- > 4 files changed, 87 insertions(+), 42 deletions(-) Reviewed-by: Max Reitz