From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@nodalink.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V2 7/8] throttle: Add throttle group support
Date: Tue, 02 Sep 2014 16:37:40 -0600 [thread overview]
Message-ID: <540646B4.6030704@redhat.com> (raw)
In-Reply-To: <1407939839-27483-8-git-send-email-benoit.canet@nodalink.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 08/13/2014 08:23 AM, Benoît Canet wrote:
> The throttle group support use a cooperative round robin scheduling algorithm.
>
> The principle of the algorithm are simple:
s/are/is/
> - Each BDS of the group is used as a token in a circular way.
> - The active BDS compute if a wait must be done and arm the right timer.
s/compute/computes/
s/arm/arms/
> - If a wait must be done the token timer will be armed so the token will become
> the next active BDS.
>
> Signed-off-by: Benoit Canet <benoit.canet@nodalink.com>
> ---
> +++ b/qapi/block-core.json
> @@ -886,6 +886,9 @@
> #
> # @iops_size: #optional an I/O size in bytes (Since 1.7)
> #
> +#
> +# @group: #optional throttle group name (Since 2.2)
Extra blank comment line.
Interface seems okay; I haven't looked closely at the code.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-02 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 14:23 [Qemu-devel] [RFC V2 0/8] Throttle group cooperative round robin scheduling Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 1/8] throttle: Extract timers from ThrottleState into a separate ThrottleTimers structure Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 2/8] throttle: Add throttle group infrastructure Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 3/8] throttle: Add throttle group infrastructure tests Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 4/8] throttle: Prepare to have multiple timers for one ThrottleState Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 5/8] throttle: Add a way to know if throttle_schedule_timer had armed a timer Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 6/8] throttle: Add a way to fire one of the timers asap like a bottom half Benoît Canet
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 7/8] throttle: Add throttle group support Benoît Canet
2014-09-02 22:37 ` Eric Blake [this message]
2014-08-13 14:23 ` [Qemu-devel] [RFC V2 8/8] throttle: Update throttle infrastructure copyright Benoît Canet
2014-08-20 14:27 ` [Qemu-devel] [RFC V2 0/8] Throttle group cooperative round robin scheduling Benoît Canet
2014-09-01 14:34 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540646B4.6030704@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).