From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP6fI-0000WI-6G for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:15:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP6fC-0000yF-Lg for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:15:43 -0400 Message-ID: <5406DC25.4010303@redhat.com> Date: Wed, 03 Sep 2014 17:15:17 +0800 From: Jason Wang MIME-Version: 1.0 References: <1409734912-6932-1-git-send-email-mst@redhat.com> In-Reply-To: <1409734912-6932-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost-scsi: init backend features earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-stable@nongnu.org On 09/03/2014 05:02 PM, Michael S. Tsirkin wrote: > As vhost core uses backend_features during init, > clear it earlier to avoid using uninitialized > memory. > This is harmless since vhost scsi ignores the result > anyway, but it avoids valgrind errors. > > Cc: qemu-stable@nongnu.org > Cc: Jason Wang > Signed-off-by: Michael S. Tsirkin > --- > hw/scsi/vhost-scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c > index ddfe76a..7146e0e 100644 > --- a/hw/scsi/vhost-scsi.c > +++ b/hw/scsi/vhost-scsi.c > @@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) > s->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues; > s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs); > s->dev.vq_index = 0; > + s->dev.backend_features = 0; > > ret = vhost_dev_init(&s->dev, (void *)(uintptr_t)vhostfd, > VHOST_BACKEND_TYPE_KERNEL, true); > @@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) > strerror(-ret)); > return; > } > - s->dev.backend_features = 0; > > error_setg(&s->migration_blocker, > "vhost-scsi does not support migration"); Acked-by: Jason Wang