From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, Chunyan Liu <cyliu@suse.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions
Date: Wed, 03 Sep 2014 06:01:50 -0600 [thread overview]
Message-ID: <5407032E.2080709@redhat.com> (raw)
In-Reply-To: <20140903084937.GA18021@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On 09/03/2014 02:49 AM, Daniel P. Berrange wrote:
> On Wed, Sep 03, 2014 at 02:18:07PM +0800, Chunyan Liu wrote:
>> Add umask to _virCommand, allow user to set umask to command.
>> Set umask(002) to qemu process to overwrite default umask(022) so
>> that unix sockets created for virtio-serial has expected permissions.
>>
> ACK, you could possibly argue that it should be configurable in
> qemu.conf, but I think that would be overkill. We unconditionally
> put QEMU into a special group, so we really should make sure that
> stuff is accessible to that group via umask.
Pushed with amended subject line. It would also be nice to enhance
tests/commandtest.c to cover this addition, but that can be a separate
patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-03 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 6:18 [Qemu-devel] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions Chunyan Liu
2014-09-03 8:49 ` Daniel P. Berrange
2014-09-03 12:01 ` Eric Blake [this message]
2014-09-03 10:06 ` [Qemu-devel] [libvirt] " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5407032E.2080709@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=cyliu@suse.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).