From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP9GA-0005fS-R9 for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:02:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP9G5-0002iJ-SM for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:01:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP9G5-0002iF-Kw for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:01:53 -0400 Message-ID: <5407032E.2080709@redhat.com> Date: Wed, 03 Sep 2014 06:01:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409725087-30483-1-git-send-email-cyliu@suse.com> <20140903084937.GA18021@redhat.com> In-Reply-To: <20140903084937.GA18021@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7cqK0OEV51IjfKhtb5pDwG0AS67rFC5IK" Subject: Re: [Qemu-devel] [libvirt] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Chunyan Liu Cc: libvir-list@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7cqK0OEV51IjfKhtb5pDwG0AS67rFC5IK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/03/2014 02:49 AM, Daniel P. Berrange wrote: > On Wed, Sep 03, 2014 at 02:18:07PM +0800, Chunyan Liu wrote: >> Add umask to _virCommand, allow user to set umask to command. >> Set umask(002) to qemu process to overwrite default umask(022) so >> that unix sockets created for virtio-serial has expected permissions. >> > ACK, you could possibly argue that it should be configurable in > qemu.conf, but I think that would be overkill. We unconditionally > put QEMU into a special group, so we really should make sure that > stuff is accessible to that group via umask. Pushed with amended subject line. It would also be nice to enhance tests/commandtest.c to cover this addition, but that can be a separate patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7cqK0OEV51IjfKhtb5pDwG0AS67rFC5IK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUBwMuAAoJEKeha0olJ0NqpbgH/RLLJShseR7OnysW0livwb7A 0ULxJ7fIY/eeoHxFqOEzFSwX5Sg74vJ1mtVYVeEynCxKGCp0GkiNiC+bEREW1f4I E2lYb/Jqd2vLVkNhRR+JII70fHhJH6BulBeWJ99n2Hxn5dUAf1zVpxEW+wk0LIqO FIt/5tbia0o45woHS7toJ0UjZr9GMvhbzdbfibhyJQSKP0ycLAWl8Em75Of3qD9t uBHegApLgCQ1UxNU9Nudamq0zVOyxXogx49O50mZbpMkl3udOxxaKUv/bv1uCHfM B/owmU/0bOmxpAGxVQ5QUGgcJeoDbrNC1/6S4p1XXk138MFrzi5cdD4vbt9mxt4= =1s6T -----END PGP SIGNATURE----- --7cqK0OEV51IjfKhtb5pDwG0AS67rFC5IK--